How can I download a huge file via TIdHTTP?
10,241
TMemoryStream
provides an in-memory buffer, so if you download into one, you need to have enough memory to hold everything you receive. It's not the only kind of stream, though. You can pass the Get
method any kind of stream you want, including one that writes its contents to disk as it receives it. Use TFileStream
, for example.
var
s: TStream;
s := TFileStream.Create('myfile.zip', fmCreate);
try
IdHttp1.Get(..., s);
finally
s.Free;
end;
Anywhere you call LoadFromFile
or SaveToFile
on a TMemoryStream
, it's possible that TFileStream
is a better choice.
Related videos on Youtube
Author by
Red October
Updated on June 04, 2022Comments
-
Red October over 1 year
I use this code to download small files:
Var ms:TMemoryStream; begin ms:=TMemoryStream.Create; Idhttp1.get('http://mydomain.com/myfile.zip',ms); ms.SaveToFile('myfile.zip'); ms.Free; end;
But file is saved in RAM before storing to disk, so it may be difficult to download files >1Gb, for example. Is there a way to download a file by its parts? Or do I need to use the WinInet? Thanks in advance!
-
Ken White over 10 yearsThe easiest option is to just use a
TFileStream
instead of aTMemoryStream
, which would write to disk directly as the file is downloaded.IdHTTP.Get
just asks for aTStream
, which means you can provide any type of stream to it. -
TLama over 10 yearsIt's like @Ken says, simply replace
TMemoryStream
with theTFileStream
. And anyway, don't forget to ensecure the stream to be released by usingtry..finally
block. Your code might be finally modified tosomething like this
.
-
-
Red October over 10 yearsThanks, exactly what I need.
-
Remy Lebeau over 10 yearsI would go a step further by using an extra
try/except
to delete the file after callings.Free()
ifGet()
failed. With the code you showed, the file is not deleted if the download fails. Unless you want to support resuming broken downloads, in which case don't delete the file.