Can I make a PHP function to create text input fields?

Question

So I'm going to be making a couple forms with multiple text input boxes, so I figured making a function to help automate this would be a good idea.

Below is the function I've come up with: however, the results I've gotten seem to be really weird, being a combination of "echo" and a mess of single quotes. Does everything look correct in there? I'm new to PHP, so I'm really sorry if it's an obvious mistake I'm missing.

    function makeTextInputField($name)
    {
echo '<label for = "<?php $name ?>"> <?php ucfirst($name) ?> </label><input type = "text" name = "<?php $name?>"></input>';
    }

Solution 1

You should not use any more tag inside the php

function makeTextInputField($name)
        {
    echo '<label for = "'.$name.'">'.ucfirst($name).'</label><input type = "text" name = "'.$name.'" />';
        }

Solution 2

Your problem is that inside PHP code you're opening new PHP tags, which actually are not required. Try this function and see if it's working for you:

function makeTextInputField($name)
{
    echo sprintf('<label for="%s">%s</label> <input type="text" name="%s"></input>', $name, ucfirst($name), $name);
}

Comments

[Admin]

The input tag must be closed with this syntax: <input />. There is no need </input>.

[elclanrs]

I guess people dont like sprintf. So sad. :(

[brasofilo]

echo sprintf() is the same as printf() :)

[mickmackusa]

echo sprintf() is an "antipattern". There is absolutely no reason that anyone should ever write echo sprintf() in any code for any reason -- it should be printf() without echo every time.

[mickmackusa]

echo sprintf() is an "antipattern". There is absolutely no reason that anyone should ever write echo sprintf() in any code for any reason -- it should be printf() without echo every time.