Change clickable TextView's color on focus and click?

97,264

Solution 1

If you want to set stateful color from code, you need to pass in ColorStateList as an argument to setTextColor passing an int to the method results in setting the color to all the states. It also looks like your xml is not totally correct. Example from ColorStateList docs looks like(should be located like this: res/color/selector_txt.xml):

 <selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:state_focused="true" android:color="@color/testcolor1"/>
    <item android:state_pressed="true" android:state_enabled="false" android:color="@color/testcolor2" />
    <item android:state_enabled="false" android:color="@color/testcolor3" />
    <item android:color="@color/testcolor5"/>
 </selector>

UPD on how to set a ColorStateList to text color:

ColorStateList cl = null;
try {
   XmlResourceParser xpp = getResources().getXml(R.color.selector_txt);
   cl = ColorStateList.createFromXml(getResources(), xpp);
} catch (Exception e) {}

Note: The method createFromXml(Resources, XmlPullParser parser) was deprecated in API level 23. Use createFromXml(Resources, XmlPullParser parser, Theme)

With XML its as easy as:

android:textColor="@color/selector_txt"

Solution 2

Step 1: Set the text color in xml like this

android:textColor="@color/text_color"

Step2: Create res/color/text_color.xml

<selector xmlns:android="http://schemas.android.com/apk/res/android" >

<item android:state_pressed="true"
      android:color="#ffffffff"/> <!-- pressed -->
<item android:state_focused="true"
      android:color="#ff0000ff"/> <!-- focused -->
<item android:color="#ff000000"/>  <!--default -->

</selector>

Solution 3

Try this one.. It worked for me:

File name: res/color/bg_tab_text_color.xml

<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
    <item android:state_pressed="false" android:state_selected="false" android:color="@color/tab_unselected_text_color"/>
    <item android:state_pressed="true" android:color="@color/tab_selected_text_color"/>
    <item android:state_pressed="false" android:state_selected="true" android:color="@color/tab_selected_text_color"/>
    <item android:color="@color/tab_unselected_text_color"></item>
</selector>

Try setting the color in xml layout as:

android:textColor="@color/bg_tab_text_color"

Solution 4

Look in R.java class (it's generated automatically). You have something like that:

 public static final class color {
        public static final int gray_transparent=0x7f050001;
}

So in your code in line:

title.setTextColor(R.color.textcolor);

you're not setting values from textcolor.xml but int from R.java (which contains textcolor.xml address). The valid way to set color is:

title.setTextColor(getResources().getColorStateList(R.color.textcolor));

Solution 5

Here is a very simple way programmatically:

private void setColorStateList(TextView view) {
        int[][] states = new int[][] {
                new int[] { android.R.attr.state_pressed}, // pressed
                new int[] { android.R.attr.state_focused}, // focused
                new int[] { android.R.attr.state_enabled}  // enabled
        };

        int[] colors = new int[] {
                getResources().getColor(R.color.blue),
                getResources().getColor(R.color.green),
                getResources().getColor(R.color.green) 
        };

        ColorStateList list = new ColorStateList(states, colors);
        view.setTextColor(list);
        view.setClickable(true);
        view.setFocusableInTouchMode(true);
    }
Share:
97,264
Daniel Jonsson
Author by

Daniel Jonsson

Working as a full stack developer. Studied software engineering at Chalmers University of Technology in Sweden. My LinkedIn profile: https://www.linkedin.com/in/dnljnssn

Updated on December 15, 2020

Comments

  • Daniel Jonsson
    Daniel Jonsson over 3 years

    I have a clickable TextView that I want to give some colors to. But I don't know how. Here are the relevant code snippets from my two files that I'm working with:

    TextView title = new TextView(this);
    title.setLayoutParams(new LayoutParams(LayoutParams.FILL_PARENT, LayoutParams.WRAP_CONTENT));
    title.setTextColor(R.color.textcolor);
    title.setText(titleLine);
    title.setTypeface(null, Typeface.BOLD);
    title.setClickable(true);
    title.setId(idLine);
    title.setFocusable(true);
    
    title.setOnClickListener(new View.OnClickListener() {
    
        @Override
        public void onClick(View v) {
    
                    /* Irrelevant code */                   
    
        }
    });
    

    And this is my textcolor.xml file:

    <?xml version="1.0" encoding="utf-8"?>
    <selector xmlns:android="http://schemas.android.com/apk/res/android">
        <item android:state_pressed="true"
              android:color="#000000"/> <!-- pressed -->
        <item android:state_focused="true"
              android:color="#000000"/> <!-- focused -->
        <item android:color="#000000"/> <!-- default -->
    </selector>
    

    When I use the textcolor-file by typing title.setTextColor(R.color.textcolor);, the textcolor just becomes grey, regardless if I press it or so. Which is strange since I have written "#000000" in all color fields.
    But if I remove the setTextColor code, gets the textView a light grey color, and when I press it, it becomes black. But that aren't the colors that I want.

    So, can anyone help me with this problem?

    Just to clarify: I want to be able to specify the colors for the text when it's normal, pressed and focused.