Get current page URL and append it to Facebook Share link (with javascript)

Question

I've been trying really hard to make the Facebook share button work, but no luck. I'd like to have the same code on ALL my pages, so I need to be able to dynamically get the current page url and append it to the Facebook share URL.

The best I could come up with is the following:

<a href="" onclick="window.open('http://www.facebook.com/share.php?u=' + 
encodeURIComponent(location.href))">Share this page</a>

https://jsfiddle.net/08x2sufs/2/

However, as you can see from the jsFiddle demo, the link does take us to a Facebook share page, but there is no page to share.

Thank you for your help.

Solution

I would use the following approach:

<a href="" id="fb_share">Share this page</a>

<script>
    window.onload = function() {
        fb_share.href ='http://www.facebook.com/share.php?u=' + encodeURIComponent(location.href); 
    }  
</script>

Comments

[Muaaz]

You just need to add var fbShareLink = document.getElementById('fb-share-link');

[Admin]

Oh, with java, my bad. Oh well, this might help some other person. ;)

[Alpi Murányi]

Hi Graham and thanks for the contribution! Can you please add some explanation to your answer? Indeed, also the clarification of the coding language used would be useful for some future readers. Thank you and keep on stackoverflowing!

[wynx]

it helped me! thanks haha. using php here