Hide/show menu onclick javascript

Question

I want to do a hide/show menu that shows when you click the p-tag with id menu and hides when you click the same p-tag — but apparently I'm useless on JavaScript. I don't want to use jQuery, I really want to learn this! Someone out there?

Here is my HTML:

<nav>
    <p id="menu"> Menu</p>
        <ul id="menu-box">
            <li><a href="index.html">Start</a></li>
            <li><a href="animal.html">Animal</a></li>
            <li><a href="pictures.html">Pictures</a></li>
        </ul>
    </nav>  

Here is my JavaScript (so far):

function setUp() {
    document.getElementById("menu").onclick = setMenu;
}

function setMenu() {
    var menuBox = document.getElementById("menu-box");
    menuBox.className = "menuBox";   
}

setUp();

Solution 1

function toggleMenu() {
  var menuBox = document.getElementById('menu-box');    
  if(menuBox.style.display == "block") { // if is menuBox displayed, hide it
    menuBox.style.display = "none";
  }
  else { // if is menuBox hidden, display it
    menuBox.style.display = "block";
  }
}

<p id="menu" onclick="toggleMenu()"> Menu</p>
<ul id="menu-box" style="display: block">
  <li><a href="index.html">Start</a></li>
  <li><a href="animal.html">Animal</a></li>
  <li><a href="pictures.html">Pictures</a></li>
</ul>

Solution 2

If your learning this drop down ,then i suggest you to learn it from this button :)

<div class="dropdown">
  <button onclick="myFunction()" class="dropbtn">Dropdown</button>
  <div id="myDropdown" class="dropdown-content">
    <a href="#">Link 1</a>
    <a href="#">Link 2</a>
    <a href="#">Link 3</a>
  </div>
</div>

and add this style

/* Dropdown Button */
.dropbtn {
    background-color: #4CAF50;
    color: white;
    padding: 16px;
    font-size: 16px;
    border: none;
    cursor: pointer;
}

/* Dropdown button on hover & focus */
.dropbtn:hover, .dropbtn:focus {
    background-color: #3e8e41;
}

/* The container <div> - needed to position the dropdown content */
.dropdown {
    position: relative;
    display: inline-block;
}

/* Dropdown Content (Hidden by Default) */
.dropdown-content {
    display: none;
    position: absolute;
    background-color: #f9f9f9;
    min-width: 160px;
    box-shadow: 0px 8px 16px 0px rgba(0,0,0,0.2);
}

/* Links inside the dropdown */
.dropdown-content a {
    color: black;
    padding: 12px 16px;
    text-decoration: none;
    display: block;
}

/* Change color of dropdown links on hover */
.dropdown-content a:hover {background-color: #f1f1f1}

/* Show the dropdown menu (use JS to add this class to the .dropdown-content container when the user clicks on the dropdown button) */
.show {display:block;}

Now toggle the hide and show with javascript

When the user clicks on the button, toggle between hiding and showing the dropdown content

function myFunction() {
    document.getElementById("myDropdown").classList.toggle("show");
}

// Close the dropdown menu if the user clicks outside of it
window.onclick = function(event) {
  if (!event.target.matches('.dropbtn')) {

    var dropdowns = document.getElementsByClassName("dropdown-content");
    var i;
    for (i = 0; i < dropdowns.length; i++) {
      var openDropdown = dropdowns[i];
      if (openDropdown.classList.contains('show')) {
        openDropdown.classList.remove('show');
      }
    }
  }
}

Comments

[Nope]

I'm assuming your class menuBox constains the css to hide the menu. If you are looking for a solution to show you how to remove a class and check if one is applied this answer will show you how ► Adding and Removing Classes, with simple cross-browser JavaScript

[Asm Hijas]

i did edited it into javascript ,Its kinda lengthy but you should see it in action :)