How to force Code Review before Check-In in TFS 2012 RC?

Question

I've just installed TFS 2012 RC and Visual Studio 2012 RC. I see some interesting feartures: Code Review, Build Success before check-in. But it do not! So my question is:

1. How to force Code Review before Check-In in TFS 2012 RC?
2. How to force "Builds" Check-in Policy (not Gated Check-in)?
3. What difference between "Builds" Check-in Policy and "Gated Check-in"?

Solution 1

1) In team explorer, go to the "Settings" section. Choose "Source Control". When the window pops up, select the "Check-in Policy" tab. Click "add" and select the options you need.

2) Create a new build. On the "Trigger" tab, change to "Continuous Integration". This will force a build with every check in.

3) Gated check in requires a successful build to check in. Continuous Integration (CI) builds on check in (both options are found on the trigger tab in the build settings, and you can actually have both on different builds) A gated check in will basically store your check in as a changeset, run a build on it, and deny the check in if the build fails. CI checks in your code and runs a build, which may or may not fail.

Hope that helps!

Solution 2

There are a couple of Code Review checkin policies that you can install in Visual Studio and configure for you Team Project. These will enforce that a Code Review work item is linked to the changes before you can check them in:

• Colin's ALM Checkin Policy Pack for Visual Studio
  • 2017
  • 2015
  • 2013
  • 2012

Comments

[Admin]

I've created a custom check-in policy that will allow you to enforce "Code Review" at check-in time. You can get it from the VS gallery here: visualstudiogallery.msdn.microsoft.com/…

[Vinh]

1. There's no "Code Review" option in "Check-in Policy" tab! How could I add?

[Andrew Clear]

Sorry, I thought there was. It is possible to create your own custom check in policy however. This blog post should get you started. link

[Vinh]

Thanks, but I think I will waiting for TFS PowerTools 2012 or TFS 2012 RTM. And I hope Microsoft will support it natively.

[Andrew Clear]

Here's the power tools for the rc: link

[Betty]

This may be an interesting read - Code Review Before or After Checkin - geekswithblogs.net/TarunArora/archive/2012/09/18/… . The only way I know how to do the force peer review is to remove developers ability to checkin and only allow them to shelve, the reviewer would effectively unshelve and check it in on their behalf.

[Fetchez la vache]

@aclear16 is there anything to stop users from removing the policies you have set?

[Andrew Clear]

@Fetchez: Fire them and hire people who want to be part of your team.

[Andrew Clear]

Check to make sure the policies are installed inside the build logic for your gated check-in build: social.msdn.microsoft.com/Forums/en-US/tfsprocess/thread/…

[Neville]

@Vinh, the code review option for TFS2012 is in the "Check-in Notes" section, not the "Check-in policy"