How to persist List<T> property in ASP.NET Custom Control?

Question

I have the following property in a custom control:

List<myClass> _items;
public List<myClass> Items{
    get { return _items; }
    set { _items= value; }
}

In my codebehind, I add items to the collection as in...

myCustomControl.items.Add(new myClass());

However, these are not persisted across postbacks. What is the proper way to allow persistance in custom controls?

Solution 1

Yikes! Don't put a List<> into the ViewState! It'll be massive!

If you add a List<string> that contains two elements - "abc" and "xyz" into the ViewState, it'll grow by 312 bytes.

If instead you add a string[] that contains the same two elements, it'll only grow by 24 bytes.

And that's just lists of strings! You can put your classes in there as Corey Downie suggests, but your ViewState will mushroom!

To keep it a sensible size, you'll have to go to some effort to convert your list of items into arrays of strings and back again.

As an alternative, consider putting your objects into the Session: that way your objects will be stored on the server, instead of being serialized into the ViewState and sent to the browser and back.

Solution 2

if you are talking about persisting the data across postbacks of the same page then you can manually add the items to the ViewState and the retrieve them On Load.

Solution 3

You can store them in the controls viewstate

public List<myClass> Items{
    get { return this.ViewState["itemsKey"] }
    set { this.ViewState["itemsKey"]= value; }
}

Solution 4

I agree that there are issues with a List<> in viewstate but it does work. Note that there is no setter on this by design. You need a reference to the list object object and your get method can new up a list when needed.

protected List<myClass> Items
{
    get
    {
        if (ViewState["myClass"] == null)
            ViewState["myClass"] = new List<myClass>();

        return (List<myClass>)ViewState["myClass"];
    }
}

View more solutions

Comments

[Robert C. Barth]

Again, MyClass has to be serializable to store it in ViewState.

[Robert C. Barth]

Storing the items in session is probably worse than storing them in ViewState. You now have the additional problem of requiring sticky sessions in a web farm.

[teedyay]

Agreed. Sessions are soooo limited (though pretty handy when you can use them).

[andleer]

You must cast your return value in the get {}. ViewState is of type Object, not of type List<myClass>.