javascript find if value is NOT IN array

Question

My problem with this is that the loop keeps going into the if statement even for duplicate barcodes. I'm trying to enter the if statement only for unique barcodes but at the end of the loop myArray has duplicates in it....why?

var myArray = new Array();  var i = 0;
$("li.foo").each(function(){
   var iBarCode = $(this).attr('barcode');
   if( !( iBarCode in myArray ) ){
      myArray[i++] = iBarCode;
      //do something else
   }
});

Solution 1

Jquery has an inArray() function.

var myArray = new Array();  var i = 0;
$("li.foo").each(function(){
   var iBarCode = $(this).attr('barcode');
   if( $.inArray(iBarCode, myArray) == -1 ){
      myArray[i++] = iBarCode;
      //do something else
   }
});

Solution 2

The in keyword search for properties, for instance when you want to know if an object has some method available. Since you are looking for values, it always returns false.

You should instead use an array search function as Gazler advises.

Comments

[Ravan Scafi]

your code is wrong, !($.inArray(iBarCode, myArray) fails if the element is in position 0. you should use !!~($.inArray(iBarCode, myArray) instead.

[sadmicrowave]

now my loop is not entering the if statement for any barcodes! the myArray is blank at the end

[Gazler]

sadmicrowave, I wrote the if statement incorrectly, since inArray returns -1 if not found. I have updated the answer.

[sadmicrowave]

thank you that fixed it. just curious but is there a way to check if a value is in an array without jquery? like indexOf() or something?

[Gazler]

indexOf is not supported in IE. See this question. stackoverflow.com/questions/1744310/…

[Oliver Tappin]

Also -1 isn't supposed in some browsers, this can be set as 'undefined'.

[gcb]

and if not using jquery, just use if( myArray.indexOf(iBarCode) === -1 ){ // do something else }