PHP - rmdir (permission denied)

Question

I have an easy script to create and delete a folder, but when I try to delete a folder, it brings up and error.

The code:

<?php
if ($_POST['hidden']) {
$key = "../g_test/uploads";
$new_folder = $_POST['nazevS'];
$new_dir_path = $key."/".$new_folder;
$dir = mkdir($new_dir_path);    
if($dir)
chmod ($new_dir_path, 0777); 
}
if ($_POST['hiddenSS']) {
$key = "../g_test/uploads";
$new_folder = $_POST['nazevS'];
rmdir($key."/".$new_folder);
}
?>

The error msg:

Warning: rmdir(../g_test/uploads/) [function.rmdir]: Permission denied in /home/free/howto.cz/m/mousemys/root/www/g_test/upload.php on line 51

Does anyone know how to delete the folder (hopefuly with everything inside) ? Also if you see any other improvments, the code could have, feel free to tell me. :-)

Thanks, Mike.

Solution 1

Generally speaking PHP scripts on Unix/Linux run as user "nobody", meaning they need the "all" privileges so it's a permissions problem with the directory. Also, to delete a file or directory in Linux/Unix you need write privileges on the parent directory. That might be your problem.

If you have problems with the files or directories you create, use chmod() on them to set the right permissions.

Also it might not be empty.

Also, it's worth mentioning that

$new_folder = $_POST['nazevS'];
$new_dir_path = $key."/".$new_folder;

is really bad from a security point of view. Sanitize that input.

Solution 2

For the purpose of this answer, I will put the security risks of allowing any and all uploads in a directory aside. I know it's not secure, but I feel this issue is outside the scope of the original question.

As everybody said, it can be a permission problem. But since you've created the directory in your code (which is most likely running as the same user when deleted). It doubt it is that.

To delete a directory, you need to make sure that:

1. You have proper permissions (as everyone pointed out).

2. All directory handles must be closed prior to deletion.
   (leaving handles open can cause Permission denied errors)

3. The directory must be empty. rmdir() only deletes the directory, not the files inside. So it can't do its job if there is still stuff inside.

To fix number 2, it is extremely simple. If you are using something like this:

$hd = opendir($mydir);

Close your handle prior to deletion:

closedir($hd);

For number 3, what you want to do is called a recursive delete. You can use the following function to achieve this:

function force_rmdir($path) {
  if (!file_exists($path)) return false;

  if (is_file($path) || is_link($path)) {
    return unlink($path);
  }

  if (is_dir($path)) {
    $path = rtrim($path, DIR_SEPARATOR) . DIR_SEPARATOR;

    $result = true;

    $dir = new DirectoryIterator($path);

    foreach ($dir as $file) {
      if (!$file->isDot()) {
        $result &= force_rmdir($path . $file->getFilename(), false, $sizeErased);
      }
    }

    $result &= rmdir($path);
    return $result;
  }
}