"Int" multiplication in c++ with "long long" result
10,325
Solution 1
Intermediate result type is the same as first argument type in this case. So this code puts wrong value into sqr
(because here you have integer overflow). Try this:
long long num = 77778;
long long sqr = num * num;
Another way with casting:
int num = 77778;
long long sqr = (long long) num * num;
To understand it better you can check these lines:
int ia = 1, ib = 2;
double da = 1.0, db = 2.0;
double ic = ia / ib; // c == 0.0, because intermediate result of division is 0
double dc = da / db; // c == 0.5, expected result
Solution 2
If you multiply two integer values, the result will be an integer value. Then, the assignment of integer value to long long is meaningless.
So, to get the desired result the num should be long long also.
Comments
-
srip almost 2 years
I am trying to find the square of a
int
. My code looks like below:long long sqr=0; int num=77778; sqr= num*num;
The result should have been
6049417284
But when I check the output it shows1754449988
. What is the mistake I am doing?long long
should be able to store the result but why am I getting a different value? -
srip about 8 yearsI am trying to understand the mistake in my code. Shouldn't the result be getting stored properly with my code?
-
Richard Critten about 8 years@rowang The intermediate result before it is stored is the same as the argument types.