RecyclerView inside ScrollView is not working

Question

I'm trying to implement a layout which contains RecyclerView and ScrollView at the same layout.

Layout template:

<RelativeLayout>
    <ScrollView android:id="@+id/myScrollView">
       <unrelated data>...</unrealated data>

           <android.support.v7.widget.RecyclerView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:id="@+id/my_recycler_view"
            />
    </ScrollView>


</RelativeLayout>

Problems: i can scroll until the last element of ScrollView

Things i tried:

1. card view inside the ScrollView (now ScrollView contains RecyclerView) - can see the card up until the RecyclerView
2. initial thought was to implement this viewGroup using RecyclerView instead of ScrollView where one of it's views type is the CardView but i got the exact same results as with the ScrollView

Solution 1

use NestedScrollView instead of ScrollView

Please go through NestedScrollView reference document for more information.

and add recyclerView.setNestedScrollingEnabled(false); to your RecyclerView

Solution 2

I know I am late it the game, but the issue still exists even after google has made fix on the android.support.v7.widget.RecyclerView

The issue I get now is RecyclerView with layout_height=wrap_content not taking height of all the items issue inside ScrollView that only happens on Marshmallow and Nougat+ (API 23, 24, 25) versions.
(UPDATE: Replacing ScrollView with android.support.v4.widget.NestedScrollView works on all versions. I somehow missed testing accepted solution. Added this in my github project as demo.)

After trying different things, I have found workaround that fixes this issue.

Here is my layout structure in a nutshell:

<ScrollView>
  <LinearLayout> (vertical - this is the only child of scrollview)
     <SomeViews>
     <RecyclerView> (layout_height=wrap_content)
     <SomeOtherViews>

The workaround is the wrap the RecyclerView with RelativeLayout. Don't ask me how I found this workaround!!! ¯\_(ツ)_/¯

<RelativeLayout
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:descendantFocusability="blocksDescendants">

    <android.support.v7.widget.RecyclerView
        android:layout_width="match_parent"
        android:layout_height="wrap_content" />

</RelativeLayout>

Complete example is available on GitHub project - https://github.com/amardeshbd/android-recycler-view-wrap-content

Here is a demo screencast showing the fix in action:

Solution 3

Although the recommendation that

you should never put a scrollable view inside another scrollable view

Is a sound advice, however if you set a fixed height on the recycler view it should work fine.

If you know the height of the adapter item layout you could just calculate the height of the RecyclerView.

int viewHeight = adapterItemSize * adapterData.size();
recyclerView.getLayoutParams().height = viewHeight;

Solution 4

In case setting fixed height for the RecyclerView didn't work for someone (like me), here is what I've added to the fixed height solution:

mRecyclerView.addOnItemTouchListener(new RecyclerView.OnItemTouchListener() {
    @Override
    public boolean onInterceptTouchEvent(RecyclerView rv, MotionEvent e) {
        int action = e.getAction();
        switch (action) {
            case MotionEvent.ACTION_MOVE:
                rv.getParent().requestDisallowInterceptTouchEvent(true);
                break;
        }
        return false;
    }

    @Override
    public void onTouchEvent(RecyclerView rv, MotionEvent e) {

    }

    @Override
    public void onRequestDisallowInterceptTouchEvent(boolean disallowIntercept) {

    }
});

Solution 5

The new Android Support Library 23.2 solves that problem, you can now set wrap_content as the height of your RecyclerView and works correctly.

Android Support Library 23.2

View more solutions

Comments

[Krutik]

How to get adapterItemSize in recyclerview any idea?

[PGMacDesign]

Indeed, this worked well for me. With this in place, I was able to move the scroll view up and down, and when I select the recyclerview for scrolling, it takes priority over the scroll view. Thanks for the tip

[Ersen Osman]

I set the height to be fixed but this disabled scrolling for me. How would i re-enable it. I simply did the above code amount of dp to px times size of items.

[Vaibhav Jani]

It works like a charm! Little correction it should be : int viewHeight = adapterItemSize * adapterData.size(); recyclerView.getLayoutParams().height = viewHeight;

[BigBen3216]

it worked for me too, just be sure to use getParent on a direct child of the scrollview

[droidster.me]

How to find out adapterItemSize?

[Ashkan]

i have a page with more than one Recycler, is there any other way to persuade this? some thing like instagram or google play part comment that load more record when you click on more comment

[EC84B4]

make it a single recyclerView and put your views as items for that recycler

[Simon]

This would work only provided that your children can be garbaged collected as soon as you scroll them out of view. If you have children that are mapFragments or streetviews, it doesn't make sense as they are forced to reload each time they scroll off the recyclerview. Embedded them into a scrollview and then generating a recyclerview at the bottom makes more sense then.

[IgorGanapolsky]

@JoakimEngstrom What is the adapterItemSize variable?

[IgorGanapolsky]

That is nonsense. You can have nested RecyclerViews just fine.

[Asthme]

it will work.but it still consumes some event .not good for performance

[ernazm]

@Simon there's handy setIsRecyclable() in ViewHolder

[H Raval]

when i put recyclerview inside scroll view, my adapter is never call....any suggestion?

[HappyKatz]

This method works on cyanogenmod distributions as well. The fixed height solution on cyanogenmod works, but only if the fixed height is the absolute height of all of the items in the list, which defies the point of using the recyclerview in the first place. Upvoted.

[Joakim Engstrom]

For those having problems with touch events, either see if you override onInterceptTouch anywhere, and see what is done there. If you don't maybe it's a good idea too look at that api. Touch events are a tricky thing in android.

[Eshaan]

Couldn't you call setNestedScrollingEnabled(false) on the recyclerview?

[winsontan520]

Tested working fine using v23.2.1 . Was using it for adding layout above recyclerview.

[Milan Gajera]

How can i call this class when we set the data to adapter?

[abhishesh]

Avoid recycler view inside Scroll view, because scroll view give its child infinite space. This causes recycler view having wrap_content as height to measure infinitely in vertical direction(till the last item of recycler view). Instead of using recycler view inside scroll view, use only recycler view with different item types. With this implementation, children of scroll view would behave as as view type. Handle those viewtypes inside recycler view.

[behelit]

doesn't fling properly too (23.4.0)

[cyroxis]

RecyclerView replaces ListView it is not meant to replace ScrollView.

[Samad]

just the RecyclerView scrolling and the ScrollView not scrolling

[Samad]

@behelit 23.4.0 have some issues code.google.com/p/android/issues/detail?id=210085#makechange‌​s , use 23.2.1 instead

[Masoud Dadashi]

nested scroll view is made for such a purpose already. this recommendations is not recommended?

[MohanRaj S]

Bro, Still have the Same Problem After changed into NestedScrollview from the Scrollview.

[royB]

mmm...can you share some code...I'm having zero issues but u can never know with this kind of issues

[Joakim Engstrom]

@MasoudDadashi Yes, you are right, this answer is not the best answer anymore.

[Cocorico]

Works with : android.support.v4.widget.NestedScrollView

[Analizer]

I also needed recyclerView.setNestedScrollingEnabled(false);

[rahulrvp]

using simple wrap_content as layout_height worked for me. No need of calculating the height.

[Tapa Save]

What about layouts below RecyclerView?

[Zeeshan Shabbir]

that works as well. You just need to use. NestedScrollView instead of scroll view

[Tapa Save]

Yes, only NestedScrollView. But solution with NestedScrollView+RecycleView call very slow populations of RecyclerView (I think for calcutaion of Y-position of first view after RecyclerView)

[Corey Horn]

This answer is now outdated. We have things like NestedScrollView that allow for nested scrollable views. Nested RecyclerViews also now work.

[Sagar Chavada]

Thanks man.. its help a lot.. but scrolling become hard after your solution so i set recyclerview.setNestedScrollingEnabled(false); and now its work like a charm.

[Sarath Babu]

keep android:layout_height="wrap_content" for the layout inflated for ViewHolder

[Kai Wang]

This comment deserves better. It is a solution, and even better than the accepted one.

[androidXP]

Is this method recycle views? if we have around hundreds of object to be recycle. This is hack not solution.

[maruti060385]

doesnt even fling properly on 25.0.1

[Roman Samoilenko]

In a complex layout NestedScrollView lags for me, unlike the ScrollView. Searching for a solution without using NestedScrollView

[Hossain Khan]

Yes, @androidXP is right, this hack is not a solution for a long list. My use case was fixed item in a list view which was less than 10. And as for how I found the other workaround, I was trying random things, this was one of them :-)

[Amir Ziarati]

perfect.solved my problem in adnroid marshmallow and upper. ;)

[jk7]

Some comments on a similar answer say disabling nested scrolling defeats the purpose of using a RecyclerView, i.e. that it won't recycle views. Not sure how to confirm that.

[jk7]

Setting nestedScrollingEnabled="false" causes RecyclerView to NOT recycle its views, at least in my setup (a RecyclerView inside a NestedScrollView). Confirmed by adding a RecyclerListener to the RecyclerView and setting a breakpoint inside its onViewRecycled() method.

[chetan]

It's working but my requirement is different, I have RecyclerView inside NestedScrollView and implementing paging for recyclerview and listening for the last position to fetch next data but it's not wokring, if I remove ScrollView or NestedScrollview then it's working fine. Is there any solution for this?

[Hemant Kaushik]

For below Lollipop versions: stackoverflow.com/a/43450158/7784230

[mehmet]

I think your solution is better but when I removed "setHasFixedSize(true);" it works more better

[Umar Ata]

Very bad solution, I mean we use recyclerview just to reuse the old views and if we assign the fixed height to recyclerview by your formula then recyclerview will not reuse that

[thedarkpassenger]

using RecyclerView inside NestedScrollView is calling onBindView for every item in the list even if the item is not visible. Any solution for that problem?

[thedarkpassenger]

if I use this solution, then onBindView is getting called for all the items in the list, which is not the usecase of recyclerview.

[thedarkpassenger]

using this code calls onBindView for all the items in the list even if those items are not visible in the list. This defeats the purpose of recyclerview.

[Abror Esonaliev]

android:descendantFocusability="blocksDescendants" helped me

[Liar]

Show how can I make RecyclerView recycle even inside ScollView? Thanks!

[Linh]

@Liar, currently there is no way to make RecyclerView recycle after put it to ScrollView. If you want recycle, thinking about another approach (like using RecyclerView with multiple type)

[Taufik Nur Rahmanda]

Please don't ... check your memory usage. This hack is killing what "recycler" means.

[Hossain Khan]

As I mentioned earlier, this is intended for a small list. I've also used it for long list with images without issue except memory consumption. So, yes, anybody planning to use this for long list is not a good idea.

[Prince Dholakiya]

In my case, I did took Horizontal RecyclerView within HorizontalScrollView and I also write this statement but It can't show me all the data which I stored in horizontal recyclerview

[kostyabakay]

Also you can add android:nestedScrollingEnabled="false" to XML instead of recyclerView.setNestedScrollingEnabled(false);

[Nanda Z]

This is not working if your data recyclerview source coming from api and you add "load more" feature. it will be load all data and would cause OutOfMemoryError

[akshay bhange]

this worked for me but I have expandable items in recyclerview & the last item expands below visible screen . this wasn't the case with scrollView

[Mostafa Arian Nejad]

It worked for me but keep in mind that the items inside recyclerView are not getting recycled.

[Hossain Khan]

The use case I had was for limited fixed size items that look similar. As I mentioned earlier, don't use if the list size is dynamic and you expect to add more items dynamically.

[Nanda Z]

it only for api level 21, how about level 19?

[Thijs]

For those who stumble onto this answer and did everything right. hasFixedSize must be set to false on recyclerview for this to work.

[CoolMind]

@NandaZ, ViewCompat.setNestedScrollingEnabled(recyclerView, false).

[CoolMind]

@Thijs, setHasFixedSize(true) works right in my case.

[Gary Chen]

You're genius! Awesome.

[martinseal1987]

you can give the recycler view a set height

[oalpayli]

You just need to give PaddingBottom into LinearLayout that is inside nestedScrollView - @thedarkpassenger

[Selva]

I used stickyScrollview, and recyclerview was going above the StickyHeader, actually it should go below, after applying your solution, it worked like charm :) great man and thanks a ton.

[cascal]

The correct package to use is now androidx.core.widget.NestedScrollView

[Tamoxin]

This really worked! It never occurred to me to set a touch listener at the item level. I tried (with no luck) to set a touch listener at the recyclerView level. Great solution. Cheers!

[Raykud]

@HossainKhan thank you. The fix without the nestedscroll worked for me, however its worth pointing out that ONLY RelativeLayout works, I tested Linear and Constraint and it wont work for some reason.