RecyclerView not calling onCreateViewHolder or onBindView

Question

Not getting any errors and all the data seems valid. For some reason, nether of the view related methods are being called. I have made sure of the following:

• getItemCount() is the only adapter method being called and is returning a positive integer value, (I know this will be the area you guys will look at)

  • Constructor is being called, member variables are valid.

  • Parent View is a vertical LinearLayout; no scrollview, or any other view with their own scroll properties in sight.

  • containing fragment view is created and shown on screen.

Here is the declaration in the fragment followed by the adapter. Any help would be appreciated as this has be completely baffled.

SubMenuAdapter adapter = new SubMenuAdapter(getActivity(), mContentItems);
    recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));
    recyclerView.setItemAnimator(new DefaultItemAnimator());
    recyclerView.setAdapter(adapter);

public class SubMenuAdapter extends RecyclerView.Adapter<SubMenuAdapter.ViewHolder> {
private static final String TAG = String.format("==> %S", SubMenuAdapter.class.getSimpleName());

private final List<ContentItem> mContentItems;
private Context mContext;

public SubMenuAdapter(Context context, List<ContentItem> contenItems) {
    Log.d(TAG, "Constructor called");
    mContentItems = contenItems;
    mContext = context;
}

@Override
public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
    Log.d(TAG, "onCreateViewHolder called");
    View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.row_resource_efficiency, parent, false);
    return new ViewHolder(view);
}

@Override
public void onBindViewHolder(ViewHolder holder, int position) {
    Log.d(TAG, "onBindViewHolder called");

    ContentItem item = mContentItems.get(position);
    holder.textName.setText(item.getName());
    FontSetter.setMyriadProRegular(mContext, holder.textName);
    Picasso.with(mContext).load("file://" + item.getPreviewImageDefault()).into(holder.imageIcon);
}

@Override
public int getItemCount() {
    Log.d(mContext, String.format("getItemCount: %d", mContentItems.size()));
    return mContentItems.size();
}

// ViewHolder
public static class ViewHolder extends RecyclerView.ViewHolder {

    TextView textName;
    ImageView imageIcon;

    public ViewHolder(View view) {
        super(view);
        textName = (TextView) view.findViewById(R.id.tv_resource_efficiency_option);
        imageIcon = (ImageView) view.findViewById(R.id.iv_resource_efficiency_icon);
    }
}

Solution 1

This may also help someone

First Use

recyclerView.setAdapter(adapter);

And then:

recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));

So it will look like this:

recyclerView.setAdapter(adapter);
recyclerView.setLayoutManager(new LinearLayoutManager(getActivity()));

The order is reversed

Update:

Nowadays I simply use:

app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"

on the RecyclerView in the xml

Solution 2

Been chasing answer for over an hour.

Dont forget to call this one liner before setting your adapter.

recyclerView.setLayoutManager(new LinearLayoutManager(this));

It seems that recycler view do not have default layout manager option built in so we have to programatically add it.

Cheers if you found it helpful.

Solution 3

Make sure you recycle view is not child from nestedscrollview

for example, this code will not work.

<android.support.v4.widget.NestedScrollView
    android:id="@+id/responder_scroll"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:background="@color/darkGray"
    android:clipToPadding="false"
    app:layout_behavior="@string/appbar_scrolling_view_behavior">

    <FrameLayout
        android:layout_width="match_parent"
        android:layout_height="wrap_content">

        <android.support.v7.widget.CardView
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:layout_marginTop="24dp"
            app:cardElevation="@dimen/spacing_medium"
            app:cardUseCompatPadding="true">

            <RelativeLayout
                android:layout_width="match_parent"
                android:layout_height="wrap_content">

                <TextView
                    android:id="@+id/responder_testimonial"
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_alignParentTop="true"
                    android:text="Testimonial"
                    android:textSize="@dimen/general_font_size" />

                <TextView
                    android:id="@+id/responder_counter_testimonial"
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_toRightOf="@+id/responder_testimonial"
                    android:text="170"
                    android:textSize="@dimen/general_font_size_small" />

                <Button
                    android:id="@+id/responder_btn_testimonial"
                    android:layout_width="wrap_content"
                    android:layout_height="wrap_content"
                    android:layout_alignParentRight="true"
                    android:layout_alignParentTop="true"
                    android:text="Go" />

               <view
                    android:id="@+id/responder_list_testimonial"
                    android:layout_width="match_parent"
                    android:layout_height="match_parent"
                    android:layout_below="@+id/responder_testimonial"
                    class="android.support.v7.widget.RecyclerView"/>
            </RelativeLayout>
        </android.support.v7.widget.CardView>

    </FrameLayout>
</android.support.v4.widget.NestedScrollView>

then i use,

<android.support.design.widget.CoordinatorLayout
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:fitsSystemWindows="true">

<view
    android:id="@+id/responder_list_testimonial"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:layout_below="@+id/responder_testimonial"
    class="android.support.v7.widget.RecyclerView"/>

Solution 4

I don't know if this will be helpful to anyone, but I almost had the same exact problem. My problem was not in either the fragment/class nor the recycler adapter. The problem was in parent XML layout where the actionbar took match_parent where the FrameLayout -in which the fragment is replaced- didn't get any available place to be shown. That's why the methods weren't called.

I guess similar scenarios might be the case for those facing the same problem. Double check every width and height in every XML file might be in the same tree, as the problem doesn't seem to be in the adapter at all.

Solution 5

My two pennies here. Just spent more than three hours debugging this.

Make sure that you have not used the following line carelessly.

recyclerView.setHasFixedSize(true);

Set the fixed size only when you are sure that the view would have a constant size. In case it is not, the onCreateViewHolder and onBindView methods might not get called at all.

View more solutions

Comments

[IgorGanapolsky]

Indeed this problem was caused for me by nesting my RecyclerView in a ScrollView. To solve it, I set a custom LayoutManager on my RecyclerView.

[raditya gumay]

Hi, yes your right, i also use Custom LayoutManager

[nikhil]

You saved me!! was doing exactly the same thing

[Abdul-Rahman Ahmad]

Glad my answer helped

[startoftext]

I spent forever on this. I ran into this problem even though my recycler view was not a direct child of scrollview or nested scrollview. Is this a known bug or just by design?

[raditya gumay]

i dont know exactly. but if you want to use nestedscrollview, you also should use a view inside it.

[igoris]

do you have any link to an explanation why this has to be this way?

[Aerim]

Hi @igoris sadly I do not, I only got to this solution by trial and error.

[venky]

Thanks a lot. This worked for me. Also, mentioned the same answer here

[Gabriel]

I've been looking for everywhere. And the problem was exactly that!

[Vassily]

Contrarwise, replaced ScrollView with NestedScrollView and code starts to work (ScrollView > LinearLayout > RecyclerView). Anyway, with your help

[raditya gumay]

Yes, you can do that.

[CoolMind]

Thanks! Wasted many hours on it. onBindViewHolder sometimes didn't call. In my case I wrongly added setHasStableIds(true); in adapter's constructor.

[krishnamurthy]

yes i forgot this , and tried whole day, finally ur answer helped me to cross check.

[ralphgabb]

know that feeling, and solved it in just a one line piece of code. Glad it helps.

[daneejela]

LayoutManager is one of the most annoying bugs that I've made millions of times and I always forgot about it. I'm going to print and frame on the wall: "Setup the Layout Manager!" :)

[Sankalp]

Using Firestore: 1st point works for me. wrap_content, how can I forget that :-), Kudos for the added note. Thanks for the help.

[Prashant Paliwal]

Always happy to help :)

[Aerim]

I would think that if you set the LayoutManager before the adapter it will already have measured something and it doesn't think it needs to do it again. This is just theory nothing proved

[n_r]

This was it! Thank you so much!

[who-aditya-nawandar]

Genius! But it was combination of your answer + removing @VenakteshShukla's answer

[Nadim Ansari]

Thanks man !! Solved my issue.