Send file from client to server using XMLRPC?

Question

I want to write Python code to send a file from client to server. server needs to save the file sent from the client. But my code have some bugs which I cannot fix. Below is my server code:

# server.py
from SimpleXMLRPCServer import SimpleXMLRPCServer
import os

server = SimpleXMLRPCServer(('localhost', 9000))

def save_data(data):
    handle = open("x123.dat", "wb")
    handle.write(data)
    handle.close()

server.register_function(save_data, 'save_data')
server.serve_forever()

And the client code:

# client.py
import sys, xmlrpclib

proxy = xmlrpclib.Server('http://localhost:9000')
handle = open(sys.argv[1], "rb")
proxy.save_data(handle.read())
handle.close()

But then I run my code, the client returns the following error (this is on Windows):

Traceback (most recent call last):
File "client.py", line 6, in <module> proxy.save_data(handle.read())
File "c:\python27\lib\xmlrpclib.py", line 1224, in __call__
  return self.__send(self.__name, args)
File "c:\python27\lib\xmlrpclib.py", line 1575, in __request
  verbose=self.__verbose
File "c:\python27\lib\xmlrpclib.py", line 1264, in request
  return self.single_request(host, handler, request_body, verbose)
File "c:\python27\lib\xmlrpclib.py", line 1297, in single_request
  return self.parse_response(response)
File "c:\python27\lib\xmlrpclib.py", line 1473, in parse_response
  return u.close()
File "c:\python27\lib\xmlrpclib.py", line 793, in close
  raise Fault(**self._stack[0])
xmlrpclib.Fault: <Fault 1: "<class 'xml.parsers.expat.ExpatError'>:not well-formed (invalid token): line 7, column 1">

I have some questions:

1. How to fix the above bug?

2. My code needs to transfer some big files sometimes. Since my method is so simple, I doubt that it is efficient for moving big data. Could anybody please suggest a better method to move big files? (Of course it is better to use XMLRPC on Python)

Solution 1

Server side:

def server_receive_file(self,arg):
        with open("path/to/save/filename", "wb") as handle:
            handle.write(arg.data)
            return True

Client side:

with open("path/to/filename", "rb") as handle:
    binary_data = xmlrpclib.Binary(handle.read())
client.server_receive_file(binary_data)

This worked for me.

Solution 2

You want to look into the xmlrpclib Binary object. With this class you can encode and decode to/from a base64 string.