UIActionSheet is not showing separator on the last item on iOS 7 GM

Question

It could be probably a bug on iOS7. But the last button is not separated from the previous one

As you can see from the image. This happens on both Simulator and device using iOS7 GM. Does everyone else has the same problem?

UIActionSheet *actionSheet = [[UIActionSheet alloc]
               initWithTitle:@"Title"
               delegate:self
               cancelButtonTitle:nil
               destructiveButtonTitle:nil
               otherButtonTitles:@"First", @"Second", @"Third", @"Fourth", nil];
[actionSheet showInView:self.view];

As you can see the code is quite simple. Any idea on how to fix the problem? Or some third party library I can use instead of UIActionSheet ?

Solution 1

I think ActionSheet requires a cancel button.So you can add the cancel button title.

Another way is: Specify actionSheet's cancelButtonIndex.

For example,in your case, you can add a "Cancel" in otherButtonTitles at index 4 and then specifiy actionSheet.cancelButtonIndex = 4.

Solution 2

I found a way to make it work on iPhone and iPad in the least hacky way:

1. Only init the UIActionSheet with a title
2. Add your buttons
3. Add a "CANCEL" button at last
4. set the CancelButtonIndex to that last index

I assume that the missing separator is caused by the cancel button not being recognized as a separate case when adding it first or through the init.

Solution 3

I found that adding a cancel button with an empty string after initialization works. The cancel button won't show up and the separator shows up.

[sheet addButtonWithTitle: @""];
[sheet setCancelButtonIndex: sheet.numberOfButtons - 1];

But this only works for iPad. On iPhone, an empty cancel button shows up, but I found a hacky workaround to make it work. In addition to the above, in willPresentActionSheet add this code in:

NSInteger offset = 55;
CGRect superFrame = actionSheet.superview.frame;
superFrame.origin.y += offset;
[actionSheet.superview setFrame: superFrame];

// hide underlay that gets shifted with the superview
[(UIView*)[[actionSheet.superview subviews] objectAtIndex: 0] removeFromSuperview];

// create new underlay
CGRect underlayFrame = CGRectMake(0, -offset, superFrame.size.width, superFrame.size.height);
UIView* underlay = [[UIView alloc] initWithFrame: underlayFrame];
underlay.alpha = 0.0f;
[underlay setBackgroundColor: [UIColor colorWithWhite: 0.0f alpha: 0.4f]];
[actionSheet.superview insertSubview: underlay atIndex: 0];

// simulate fade in
[UIView animateWithDuration: 0.3f animations:^{
    underlay.alpha = 1.0f;
}];

This shifts down the sheet to hide the cancel button off the screen

Solution 4

The simplest fix is to pass @"" to the cancel button title instead of nil during allocation.

UIActionSheet *actionSheet = [[UIActionSheet alloc]
               initWithTitle:@"Title"
               delegate:self
               cancelButtonTitle:@"" // change is here
               destructiveButtonTitle:nil
               otherButtonTitles:@"First", @"Second", @"Third", @"Fourth", nil];
[actionSheet showInView:self.view];

Solution 5

UIActionSheet *asAccounts = [[UIActionSheet alloc]
                            initWithTitle:Localized(@"select_an_account")
                            delegate:self
                            cancelButtonTitle:nil
                            destructiveButtonTitle:nil
                            otherButtonTitles: nil];

for (int i=0; i<[result count]; i++) {
    ACAccount *acct = [result objectAtIndex:i];
    [asAccounts addButtonWithTitle:[acct username]];
    asAccounts.tag = i;
}

[asAccounts addButtonWithTitle:Localized(@"Cancel")];                
asAccounts.cancelButtonIndex = result.count;
[asAccounts showInView:self.view];

View more solutions

Comments

[Matthias Bauch]

Most likely this is an iOS bug. File a bugreport. I see something similar in UITableViews. The separators are missing on some rows. I think it's not worth to try to fix this by using a third party library. I'm pretty sure that there will be a GM2 soon.

[wattson12]

devforums.apple.com/message/857939#857939 this suggests a workaround of passing in @"" to the cancelButtonTitle (iPad)

[nacho4d]

The workaround worked!

[JJ86]

@wattson12 this is a good workaround, but if i don't want a cancel button, what can i do?

[robotspacer]

At first I didn't think this was ideal, but what I didn't realize is that if you add a cancel button, iPad is smart enough to not display it. (This is true in iOS 6 as well.) Since iPhone should have a cancel button this solution works perfectly.

[Stephen Watson]

"I think ActionSheet requires a cancel button ..." is not the case. Apple state in the documentation: " ... Specify nil if you do not want a cancel button or are presenting the action sheet on an iPad." However, adding @"" instead of nil works for me as posted below.

[Legoless]

This is the proper way.

[Sebastian Greifeneder]

Agree, after wasting a day on this problem (UIActionSheet consistent for iPhone/iPad and iOS7/iOS8) I've ended up using this approach. Additionally I'm adding the destructive button between step 1 and 2 (i.e. as first button).