User control click event not working when clicking on text inside control?

Question

I have a user control called GameButton that has a label inside it. When I add the user control to my form, and add a click event to it, its triggered when you click on the background of the custom button, but not the text in the label? How would I fix this without adding a bunch of click events inside the user controls code?

edit: UI framework: winforms

Solution 1

If I am understanding you properly, your GameButton usercontrol will fire the event when clicked on, but not when the label is clicked on -- and you want both. This is because the label (a control) is on top of the background. Therefore, you need to register your label with the click event as well. This can be done manually in the designer or programmatically for each control on the page.

If you want to do EVERY control in the UserControl, put this into the UserControl's OnLoad event and you can use the same click event for every control:

foreach (var c in this.Controls)
    c.Click += new EventHandler(yourEvent_handler_click);

public void yourEvent_handler_click (object sender, EventArgs e){
    //whatever you want your event handler to do
}

EDIT: The best way is to create the click event handler property in the user control. This way, every time you add/remove a click event to your user control, it adds/removes it to all the controls within the user control automatically.

public new event EventHandler Click {
        add {
            base.Click += value;
            foreach (Control control in Controls) {
                control.Click += value;
            }
        }
        remove {
            base.Click -= value;
            foreach (Control control in Controls) {
                control.Click -= value;
            }
        }
    }

This is as per another post:

Hope this helps!

Solution 2

You can create a new method and assign all the controls to it

private void Control_Click(object sender, EventArgs e)
{
   this.OnClick(e);
}

This will raise main control(or usercontrol) event.

Solution 3

Set the "enable" property of your labels "False, then mouse events will work in user control.

Comments

[Oztaco]

I wanted to be able to add click events to my custom buttons the way you do with regular buttons in the designer, but they don't affect the label

[ImGreg]

I'm not sure I understand @EfeOzturkoglu. You want your usercontrol to be as if it were a regular button where you can click on it anywhere with one event handler?

[Oztaco]

yeah, like i dont want to have to add a handler to the control AND the label inside it each time, just add it once whenever i create a new instance of the button

[ImGreg]

@EfeOzturkoglu No problem. Glad to help.

[lolbas]

Wrong solution as this will also gray out controls.

[FSRezende]

its works to me! i set enable false for all child controls in my user control!

[moumouh206]

Thank you sir!! this is a clever solution