What is an anti-pattern?

Question

I am studying patterns and anti-patterns. I have a clear idea about patterns, but I don't get anti-patterns. Definitions from the web and Wikipedia confuse me a lot.

Can anybody explain to me in simple words what an anti-pattern is? What is the purpose? What do they do? Is it a bad thing or good thing?

Solution 1

Anti-patterns are certain patterns in software development that are considered bad programming practices.

As opposed to design patterns which are common approaches to common problems which have been formalized and are generally considered a good development practice, anti-patterns are the opposite and are undesirable.

For example, in object-oriented programming, the idea is to separate the software into small pieces called objects. An anti-pattern in object-oriented programming is a God object which performs a lot of functions which would be better separated into different objects.

For example:

class GodObject {
    function PerformInitialization() {}
    function ReadFromFile() {}
    function WriteToFile() {}
    function DisplayToScreen() {}
    function PerformCalculation() {}
    function ValidateInput() {}
    // and so on... //
}

The example above has an object that does everything. In object-oriented programming, it would be preferable to have well-defined responsibilities for different objects to keep the code less coupled and ultimately more maintainable:

class FileInputOutput {
    function ReadFromFile() {}
    function WriteToFile() {}
}

class UserInputOutput {
    function DisplayToScreen() {}
    function ValidateInput() {}
}

class Logic {
    function PerformInitialization() {}
    function PerformCalculation() {}
}

The bottom line is there are good ways to develop software with commonly used patterns (design patterns), but there are also ways software is developed and implemented which can lead to problems. Patterns that are considered bad software development practices are anti-patterns.

Solution 2

Whenever I hear about Anti-patterns, I recollect another term viz. Design smell.

"Design smells are certain structures in the design that indicate violation of fundamental design principles and negatively impact design quality”. (From "Refactoring for Software Design Smells: Managing technical debt")

There are many design smells classified based on violating design principles:

Abstraction smells

Missing Abstraction: This smell arises when clumps of data or encoded strings are used instead of creating a class or an interface.

Imperative Abstraction: This smell arises when an operation is turned into a class.

Incomplete Abstraction: This smell arises when an abstraction does not support complementary or interrelated methods completely.

Multifaceted Abstraction: This smell arises when an abstraction has more than one responsibility assigned to it.

Unnecessary Abstraction: This smell occurs when an abstraction that is actually not needed (and thus could have been avoided) gets introduced in a software design.

Unutilized Abstraction: This smell arises when an abstraction is left unused (either not directly used or not reachable).

Duplicate Abstraction: This smell arises when two or more abstractions have identical names or identical implementation or both.

Encapsulation smells

Deficient Encapsulation: This smell occurs when the declared accessibility of one or more members of an abstraction is more permissive than actually required.

Leaky Encapsulation: This smell arises when an abstraction “exposes” or “leaks” implementation details through its public interface.

Missing Encapsulation: This smell occurs when implementation variations are not encapsulated within an abstraction or hierarchy.

Unexploited Encapsulation: This smell arises when client code uses explicit type checks (using chained if-else or switch statements that check for the type of the object) instead of exploiting the variation in types already encapsulated within a hierarchy.

Modularization smells

Broken Modularization: This smell arises when data and/or methods that ideally should have been localized into a single abstraction are separated and spread across multiple abstractions.

Insufficient Modularization: This smell arises when an abstraction exists that has not been completely decomposed, and a further decomposition could reduce its size, implementation complexity, or both.

Cyclically-Dependent Modularization: This smell arises when two or more abstractions depend on each other directly or indirectly (creating a tight coupling between the abstractions).

Hub-Like Modularization: This smell arises when an abstraction has dependencies (both incoming and outgoing) with a large number of other abstractions.

Hierarchy smells

Missing Hierarchy: This smell arises when a code segment uses conditional logic (typically in conjunction with “tagged types”) to explicitly manage variation in behavior where a hierarchy could have been created and used to encapsulate those variations.

Unnecessary Hierarchy: This smell arises when the whole inheritance hierarchy is unnecessary, indicating that inheritance has been applied needlessly for the particular design context.

Unfactored Hierarchy: This smell arises when there is unnecessary duplication among types in a hierarchy.

Wide Hierarchy: This smell arises when an inheritance hierarchy is “too” wide indicating that intermediate types may be missing.

Speculative Hierarchy: This smell arises when one or more types in a hierarchy are provided speculatively (i.e., based on imagined needs rather than real requirements).

Deep Hierarchy: This smell arises when an inheritance hierarchy is “excessively” deep.

Rebellious Hierarchy: This smell arises when a subtype rejects the methods provided by its supertype(s).

Broken Hierarchy: This smell arises when a supertype and its subtype conceptually do not share an “IS- A” relationship resulting in broken substitutability.

Multipath Hierarchy: This smell arises when a subtype inherits both directly as well as indirectly from a supertype leading to unnecessary inheritance paths in the hierarchy.

Cyclic Hierarchy: This smell arises when a supertype in a hierarchy depends on any of its subtypes.

---

The above definition and classification is described in "Refactoring for software design smells: Managing technical debt". Some more relevant resources could be found here.

Solution 3

A pattern is an idea of how to solve a problem of some class. An anti-pattern is an idea of how not to solve it because implementing that idea would result in bad design.

An example: a "pattern" would be to use a function for code reuse, an "anti-pattern" would be to use copy-paste for the same. Both solve the same problem, but using a function usually leads to more readable and maintainable code than copy-paste.

Solution 4

An anti-pattern is a way of not solving a problem. But there is more to it: it is also a way that can frequently be seen in attempts to solve the problem.

Solution 5

If you really wish to study AntiPatterns, get the book AntiPatterns (ISBN-13: 978-0471197133).

In it, they define "An AntiPattern is a literary form that describes a commonly occurring solution to a problem that generates decidedly negative consequences."

So, if it's a bad programming practice but not a common one— very limited in frequency of occurrence, it does not meet the "Pattern" part of the AntiPattern definition.

View more solutions

Comments

[jaco0646]

sourcemaking.com/antipatterns

[jaco0646]

martinfowler.com/bliki/AntiPattern.html

[tripleee]

The C2 wiki - the original wiki site, by Ward Cunningham - has a lot of material about programming patterns, and a page about AntiPatterns. (Probably visit the start page first if you are unfamiliar with the site's conceptual design. It is far removed from what people think "wiki" means these days, though it obviously inspired the architecture for platforms like Wikipedia and Wikia.)

[Tomasz Mularczyk]

any other examples of Anti-Patterns beside GodObject?

[AWrightIV]

@Tomasz Programming Pasta serves is one such example. It's best generalized as poor encapsulation between many small objects. Consider it the opposite of the God object en.wikipedia.org/wiki/Spaghetti_code

[eric]

@Tomasz anything that is bad, but is done by some people, is an antipattern. E.g., try: <do something>; except: pass may be the Cardinal Sin antipattern in Python. See this: realpython.com/blog/python/…

[hawkeyegold]

Actually, anti-patterns generally are not obvious. Obviously bad design patterns are simply bad design patterns. A genuine anti-pattern looks tenable on the surface, but manifests problems later on. In fact, not being obviously bad is the distinction that makes them an anti-pattern in the first place.

[lostsoul29]

Can a Singleton be considered an anti-pattern because it makes it harder to mock and run tests in parallel (since all tests use and mutate the same singleton, resulting in inconsistencies)?

[Matthieu]

@lostsoul29 it depends if the final purpose of your program is its ability to be tested in parallel... (And in the particular case you mention: that's a reentrant problem that should either be corrected or documented). Singleton is a pattern that should be used for what it's good at.

[pabrams]

I'd say the God class is more of an anti-pattern than a smell. Also, "singleton" isn't a very good example of an anti-pattern. If it can even be considered an anti-pattern, at all.

[pabrams]

I disagree with your interpretation of "common". You can still find common solutions, or patterns, among a company's an individual's or an application's. A progblem might be unique to that company, but that doesn't mean its bad, recurrrent solutions aren't anti-patterns.

[kmarsh]

@pabrams I get your point, one prolific programmer can make a pattern common, if only locally. I'll amend the answer.

[physincubus]

great example, thanks, this is very clarifying. Now I must go and rewrite all of my code...