WPF how do I create a textbox dynamically and find the textbox on a button click?

54,407

Solution 1

Josh G had the clue that fixed this code: use RegisterName().

Three benefits here:

  1. Doesn't use a member variable to save the reference to the dynamically created TextBox.
  2. Compiles.
  3. Complete code.

    using System;
    using System.Windows;
    using System.Windows.Controls;
    
    namespace AddControlsDynamically
    {
        public partial class Window1 : Window
        {
            public void Window_Loaded(object sender, RoutedEventArgs e)
            {
                GenerateControls();
            }
            public void GenerateControls()
            {
                Button btnClickMe = new Button();
                btnClickMe.Content = "Click Me";
                btnClickMe.Name = "btnClickMe";
                btnClickMe.Click += new RoutedEventHandler(this.CallMeClick);
                someStackPanel.Children.Add(btnClickMe);
                TextBox txtNumber = new TextBox();
                txtNumber.Name = "txtNumber";
                txtNumber.Text = "1776";
                someStackPanel.Children.Add(txtNumber);
                someStackPanel.RegisterName(txtNumber.Name, txtNumber);
            }
            protected void CallMeClick(object sender, RoutedEventArgs e)
            {
                TextBox txtNumber = (TextBox) this.someStackPanel.FindName("txtNumber");
                string message = string.Format("The number is {0}", txtNumber.Text);
                MessageBox.Show(message);
            }
        }
    }
    

Solution 2

Another method is to set the associated TextBox as Button Tag when instanciating them.

btnClickMe.Tag = txtNumber;

This way you can retrieve it back in event handler.

protected void ClickMeClick(object sender, RoutedEventArgs e)
{
    Button btnClickMe = sender as Button;
    if (btnClickMe != null)
    {
        TextBox txtNumber = btnClickMe.Tag as TextBox;
        // ...
    }
}

Solution 3

You can get your original click handler to work by registering the name of the text box:

someStackPanel.RegisterName(txtNumber.Name, txtNumber);

This will then allow you to call FindName on the StackPanel and find the TextBox.

Solution 4

If you want to do a comprehensive search through the visual tree of controls, you can use the VisualTreeHelper class.

Use the following code to iterate through all of the visual children of a control:

for (int i = 0; i < VisualTreeHelper.GetChildrenCount(parentObj); i++)
{
    DependencyObject child = VisualTreeHelper.GetChild(parent, i);

    if (child is TextBox)
        // Do something
}

If you want to search down into the tree, you will want to perform this loop recursively, like so:

public delegate void TextBoxOperation(TextBox box);

public bool SearchChildren(DependencyObject parent, TextBoxOperation op)
{
    for (int i = 0; i < VisualTreeHelper.GetChildrenCount(parent); i++)
    {
        DependencyObject child = VisualTreeHelper.GetChild(parent, i);

        TextBox box = child as TextBox;

        if (box != null)
        {
            op.Invoke(box);
            return true;
        }

        bool found = SearchChildren(child, op);

        if (found)
            return true;
    }
}

Solution 5

Is there any way you can make the TextBox control a field in your class instead of a variable inside your generator method

public class MyWindow : Window
{
    private TextBox txtNumber;

    public void Window_Loaded()
    {
        GenerateControls();
    }

    public void GenerateControls()
    {
        Button btnClickMe = new Button();
        btnClickMe.Content = "Click Me";
        btnClickMe.Name = "btnClickMe";
        btnClickMe.Click += new RoutedEventHandler(this.CallMeClick);
        someStackPanel.Childern.Add(btnClickMe);
        txtNumber = new TextBox();
        txtNumber.Name = "txtNumber";
        txtNumber.Text = "1776";
        someStackPanel.Childern.Add(txtNumber);
    }

    protected void ClickMeClick(object sender, RoutedEventArgs e)
    {    
        // Find the phone number    
        string message = string.Format("The number is {0}", txtNumber.Text);        
        MessageBox.Show(message);
    }
}
Share:
54,407
David Basarab
Author by

David Basarab

David Basarab Software craftsman that is constantly scrubbing my code.

Updated on July 09, 2022

Comments

  • David Basarab
    David Basarab almost 2 years

    I am creating a TextBox and a Button dynamically using the following code:

    Button btnClickMe = new Button();
    btnClickMe.Content = "Click Me";
    btnClickMe.Name = "btnClickMe";
    btnClickMe.Click += new RoutedEventHandler(this.CallMeClick);
    
    someStackPanel.Childern.Add(btnClickMe);
    
    TextBox txtNumber = new TextBox();
    txtNumber.Name = "txtNumber";
    txtNumber.Text = "1776";
    
    someStackPanel.Childern.Add(txtNumber);
    

    I hook up to a click event to the Click Me button. The click me button even is fired correctly. However I cannot find the TextBox I entered dynamically.

    Here is my click me event:

    protected void ClickMeClick(object sender, RoutedEventArgs e)
    {
        // Find the phone number
        TextBox txtNumber = this.someStackPanel.FindName("txtNumber") as TextBox;
    
        if (txtNumber != null)
        {
            string message = string.Format("The number is {0}", txtNumber.Text);
    
            MessageBox.Show(message);    
        }
        else
        {
            MessageBox.Show("Textbox is null");
        }
    }
    

    How can I find the TextBox txtNumber?