Manually instantiate a Controller instance from an arbitrary URL?
Solution 1
Hmm... I don't know if this is the best solution because it requires mocking, but maybe this will help. You're on the right track and the controller factory part is simple once you know what controller to instantiate, so the question is what's the fastest way to get a RouteData object from an arbitrary url.
And the only way I know how would be like so, with Moq:
string url = "~/Account/LogOn"; //trying to create Account controller in default MVC app
RouteCollection rc = new RouteCollection();
MvcApplication.RegisterRoutes(rc);
System.Web.Routing.RouteData rd = new RouteData();
var mockHttpContext = new Moq.Mock<HttpContextBase>();
var mockRequest = new Moq.Mock<HttpRequestBase>();
mockHttpContext.Setup(x => x.Request).Returns(mockRequest.Object);
mockRequest.Setup(x => x.AppRelativeCurrentExecutionFilePath).Returns(url);
RouteData routeData = rc.GetRouteData(mockHttpContext.Object);
string controllerName = routeData.Values["controller"].ToString();
IControllerFactory factory = ControllerBuilder.Current.GetControllerFactory();
IController controller = factory.CreateController(this.ControllerContext.RequestContext, controllerName);
I did quite a bit of googling and couldn't find much that didn't pertain to unit testing/mocking. I don't know if there is a quick and easy to do this, but would certainly like to know if someone has a better solution!
Solution 2
Okay, after working with this for a couple weeks, this is what I ended up with. It works like a charm and avoids dependencies on mocks, but still feels hacky to me.
// Get the application's route collection.
UrlRoutingModule module = new UrlRoutingModule();
RouteCollection col = module.RouteCollection;
// Fake a request to the supplied URL into the routing system
string originalPath = this.HttpContext.Request.Path;
this.HttpContext.RewritePath(urlToGetControllerFor);
RouteData fakeRouteData = col.GetRouteData(this.HttpContext);
// Get an instance of the controller that would handle this route
string controllername = fakeRouteData.Values["controller"].ToString();
var ctxt = new RequestContext(this.ControllerContext.HttpContext, fakeRouteData);
IController controller = ControllerBuilder.Current.GetControllerFactory()
.CreateController(ctxt, controllername);
// Reset our request path.
this.HttpContext.RewritePath(originalPath.ToString());
So far there have been absolutely no downstream side effects of the RewritePath()
calls. Thanks to Kurt for his code, and if anyone can come up with something better, please don't hesitate to post.
Related videos on Youtube
nuiun
Many years of C#/ASP.Net MVC/SQL Server behind me, now working with Node.js, Golang, Python, Docker and AWS full time. Certified as a MongoDB DBA. Currently leading several development teams in trying to force the music industry into the 21st century. I have a dynamic leadership style, putting people first and watching the software follow. Highly interested in Ethereum and dabbling in Solidity. Been working with Hyperledger Fabric, Sawtooth and Caliper for the last several months. Mining altcoins since 2014.
Updated on April 19, 2022Comments
-
nuiun about 2 years
My skills are failing me, and I know I've seen the code around for this but I can't find it.
What's the quickest way to take any arbitrary URL, run it through your asp.net mvc routing system, and come out with a reference to a controller instance on the other end?
For example, code execution is inside some arbitrary controller method. I want to do something like this:
... string myURL = "http://mysite/mycontroller/myaction/myparameters"; RouteData fakeRouteData = new RouteData(Route???, IRouteHandler???) RequestContext ctxt = new RequestContext(this.ControllerContext.HttpContext, fakeRouteData); ControllerFactory factory = ControllerBuilder.Current.GetControllerFactory(); Controller result = factory.CreateController(ctxt, controllername???)
I'm trying to get an instance of a controller just like the routing system does, regardless of where the code is executing. I'm unclear as to how to fit the pieces together at this point. While I will eventually discover it, I thought I could save time by asking here ;)
-
VitalyB over 10 yearsI wrote a full sample that doesn't involve mock [here][1]. [1]: stackoverflow.com/a/19382567/126574
-
-
nuiun over 14 yearsThanks for the response. I actaully want to leverage the routing system anywhere in my code. I'll edit the question to make it a bit clearer.
-
nuiun over 14 yearsKurt - fantastic! I was just getting there when you posted this, I was about two lines off with the RouteData stuff. I think I may have a way to avoid mocks as well, using the current HttpContext - if you call this.HttpContext.RewritePath("~/Account/LogOn") it correctly finds the controller after that. I'm not sure if that is entirely safe though, since downstream consumers of the HttpContext might get confused, so I have to test it some more and may yet fall back to trusty Moq... many +1's to you.
-
Kurt Schindler over 14 yearsCool! Please post whatever you come up with. Clever thinking w/ RewritePath, but indeed that may be problematic.
-
nuiun over 14 yearsI posted what I ended up with. The RewritePath() approach seems to work and lets me avoid the mocks for now. Thanks again for your help ;)
-
Joonas Alhonen over 5 yearsI am a little bit late but do you have any information how to achieve this with .NET Core 2.1?