Using Automapper to update an existing Entity POCO

27,372

Solution 1

If you use Automapper like that, it returns a new Patient object and the references to the enity framework graph are not kept. You have to use it like this:

[HttpPost]
public ActionResult Edit(PatientView viewModel)
{
    Patient patient = db.Patients.Find(viewModel.Id); 
    Mapper.Map(viewModel, patient);
    ...
    db.SaveChanges();
    return RedirectToAction("Index");
}

Solution 2

There seem to be two approaches to dealing with the EF proxy issue:

  1. Switch off ObjectContext.ContextOptions.ProxyCreationEnabled, either for the whole application (in EF Context constructor or EDMX), or for the query where you need to guarantee getting an actual Entity object rather than a proxy.
  2. Using an extension to Automapper, documented here: https://gist.github.com/935461.

Note. The latter is commented with "Room for improvement. See: Automapper : mapping issue with inheritance and abstract base class on collections with Entity Framework 4 Proxy Pocos".

Share:
27,372
Paul Taylor
Author by

Paul Taylor

.NET Core, ASP.NET, MVC, WebAPI, React, Angular, Entity Framework, Elasticsearch and SQL Server

Updated on July 09, 2022

Comments

  • Paul Taylor
    Paul Taylor almost 2 years

    I am using EF4 DbContext to provide the model for an ASP.NET MVC app. I use ViewModels to provide data to the views and Automapper to perform the mapping between the EF POCOs and the ViewModels. Automapper does a great job but I'm not clear the best way to use it after the ViewModel is posted back to the controller to carry out an update.

    My idea is to get POCO object using a key contained in the ViewModel. I then want to use Automapper to update the POCO with data from the ViewModel:

    [HttpPost]
    public ActionResult Edit(PatientView viewModel)
    {
        Patient patient = db.Patients.Find(viewModel.Id); 
        patient = Mapper.Map<ViewModel, Patient>(viewModel, patient);
        ...
        db.SaveChanges();
        return RedirectToAction("Index");
    }
    

    Two questions:

    1. The Find() method returns a Proxy rather than a POCO which causes Automapper to complain. How do I get the POCO instead of the Proxy?
    2. Is this best practice for performing an update?
  • Paul Taylor
    Paul Taylor almost 10 years
    Yes, I believe an bug has been fixed since I posted this question, and the method you illustrate now works correctly.