Looping through a list of Actions

Question

I can't understand how to loop through an Action list. When I try it, I end up with the values being the same as the previous iteration.

Here's the code (simplified example):

string[] strings = { "abc", "def", "ghi" };

var actions = new List<Action>();
foreach (string str in strings)
    actions.Add(new Action(() => { Trace.WriteLine(str); }));

foreach (var action in actions)
    action();

Output:

ghi
ghi
ghi

Why is it always selecting the final element in strings when it performs the action?
And how can I achieve the desired output which would be:

abc
def
ghi

Solution 1

Your action is a closure, therefore it accesses str itself, not a copy of str:

foreach (string str in strings)
{
    var copy = str; // this will do the job
    actions.Add(new Action(() => { Trace.WriteLine(copy); }));
}

Solution 2

This behaviour is conditionize by Closures.

The variable that is present in your lambda is a reference and not value copy. That means that points to the latest value assumed by str, which is "ghi" in your case. That's why for every call it just goes to the same memory location and recovers, naturally, same value.

If you write the code, like in answers provided, you force a C# compiler to regenerate a new value each time, so a new address will be passed to the labmda, so every lambda will have it's own variable.

By the way, if I'm not mistake, C# team promise to fix this non natural behaviour in C# 5.0. So it's better to check their blog on this subject for future updates.

Solution 3

This is a pretty complicated situation. The short answer is to create a copy of the local variable before assigning it to the closure:

string copy = str;
actions.Add(new Action(() => { Trace.WriteLine(copy); }));

Check out this article on closures for more information.